<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106253/">http://git.reviewboard.kde.org/r/106253/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Yuri Chornoivan.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Current version of Calligra Sheets contains Solver plugin (kspreadsolver.so). This is not loaded due to the mistake in rc-file, it tries to load translation catalog "kspreadsolver" but Messages.sh extracts into tablessolver.pot, and Tables was renamed to Sheets.
This patch resolves some inconsistencies to make plugin loadable and translatable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with current git/master. Plugin loads and works as expected. After correction of catalog name (tablessolver.mo->sheetssolver.mo) it is completely translatable.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=126630">126630</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/calligra_sheets_export.h <span style="color: grey">(03168ca)</span></li>
<li>sheets/plugins/solver/CMakeLists.txt <span style="color: grey">(8ccd1f7)</span></li>
<li>sheets/plugins/solver/Messages.sh <span style="color: grey">(50839d9)</span></li>
<li>sheets/plugins/solver/Solver.cpp <span style="color: grey">(f5bbd8e)</span></li>
<li>sheets/plugins/solver/solver.rc <span style="color: grey">(4d92a29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106253/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>