Review Request: Better support for hatch background

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106115/#review17814
-----------------------------------------------------------


Quick first review...


libs/flake/KoColorBackground_p.h
<http://git.reviewboard.kde.org/r/106115/#comment14045>

    Perhaps could be done with member initialization list, like also done in KoHatchBackgroundPrivate, to save a few cycles.



libs/flake/KoHatchBackground.cpp
<http://git.reviewboard.kde.org/r/106115/#comment14050>

    Perhaps QVector::reserve(int) could be used for a minimal improvement, both here and above.



libs/flake/KoHatchBackground.cpp
<http://git.reviewboard.kde.org/r/106115/#comment14051>

    Misses to deal with any units deg, grad, rad, no?



libs/flake/KoHatchBackground.cpp
<http://git.reviewboard.kde.org/r/106115/#comment14052>

    Any reason? Compatibility with LO/AOO?


- Friedrich W. H. Kossebau


On Aug. 21, 2012, 6:07 p.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106115/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2012, 6:07 p.m.)
> 
> 
> Review request for Calligra and Jan Hambrecht.
> 
> 
> Description
> -------
> 
> Implement correct support for hatch background as defined in odf. With this patch the different styles, freely defined angles and distance between the lines of the hatch is supported.
> 
> This patch also changes the KoColorBackground to also use the d pointer of the parent which reduces the memory needed for a KoColorBackground.
> 
> 
> This addresses bugs 260534 and 298708.
>     http://bugs.kde.org/show_bug.cgi?id=260534
>     http://bugs.kde.org/show_bug.cgi?id=298708
> 
> 
> Diffs
> -----
> 
>   libs/flake/CMakeLists.txt 15b6e6c 
>   libs/flake/KoColorBackground.h 88b61bd 
>   libs/flake/KoColorBackground.cpp 66d7ffc 
>   libs/flake/KoColorBackground_p.h PRE-CREATION 
>   libs/flake/KoHatchBackground.h PRE-CREATION 
>   libs/flake/KoHatchBackground.cpp PRE-CREATION 
>   libs/flake/KoShape.cpp 3a32e9f 
> 
> Diff: http://git.reviewboard.kde.org/r/106115/diff/
> 
> 
> Testing
> -------
> 
> Tested with cstester and the documents of the bug reports.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120821/169d329d/attachment.htm>