Review Request: Better support for hatch background

Thorsten Zachmann t.zachmann at zagge.de
Tue Aug 21 19:07:07 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106115/
-----------------------------------------------------------

Review request for Calligra and Jan Hambrecht.


Description
-------

Implement correct support for hatch background as defined in odf. With this patch the different styles, freely defined angles and distance between the lines of the hatch is supported.

This patch also changes the KoColorBackground to also use the d pointer of the parent which reduces the memory needed for a KoColorBackground.


This addresses bugs 260534 and 298708.
    http://bugs.kde.org/show_bug.cgi?id=260534
    http://bugs.kde.org/show_bug.cgi?id=298708


Diffs
-----

  libs/flake/CMakeLists.txt 15b6e6c 
  libs/flake/KoColorBackground.h 88b61bd 
  libs/flake/KoColorBackground.cpp 66d7ffc 
  libs/flake/KoColorBackground_p.h PRE-CREATION 
  libs/flake/KoHatchBackground.h PRE-CREATION 
  libs/flake/KoHatchBackground.cpp PRE-CREATION 
  libs/flake/KoShape.cpp 3a32e9f 

Diff: http://git.reviewboard.kde.org/r/106115/diff/


Testing
-------

Tested with cstester and the documents of the bug reports.


Thanks,

Thorsten Zachmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120821/4a8eb7fd/attachment.htm>


More information about the calligra-devel mailing list