Review Request: use QFormLayout for general document/grid/misc config pages, Karbon interface config page and Sheets Open/Save config page

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106084/#review17721
-----------------------------------------------------------

Ship it!


Ship It!

- C. Boemann


On Aug. 19, 2012, 11:16 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106084/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2012, 11:16 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> QFormLayout slightly improves the look (&feel) of the dialogs.
> 
> The patch also aligns and changes the UI strings in the general config and the Sheet config to "Autosave interval:" and "Create backup file:"
> 
> Ideally Sheets would use the Documents page as well for consistency, but:
> * it uses different config keys to store the data (could be solved by an update script though)
> * not obvious where to put the "Number of entries in Recent Files list":
>   move to "Interface" page, like Karbon has it? Or turn "Document" page into "Load/Save" page?
> 
> Until that is decided, using QFormLayouts and consistent strings in the UI is an improvement already.
> 
> 
> Diffs
> -----
> 
>   doc/sheets/configdialog.docbook ba78944 
>   doc/stage/options.docbook 30b4275 
>   karbon/ui/widgets/KarbonConfigInterfacePage.cpp 3bb0aae 
>   libs/main/config/KoConfigDocumentPage.cpp 47a0905 
>   libs/main/config/KoConfigGridPage.cpp 3b20a40 
>   libs/main/config/KoConfigMiscPage.cpp c0da74b 
>   sheets/part/dialogs/FileOptionsWidget.ui 159cf95 
> 
> Diff: http://git.reviewboard.kde.org/r/106084/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Document Settings Page Before
>   http://git.reviewboard.kde.org/r/106084/s/681/
> Document Settings Page After
>   http://git.reviewboard.kde.org/r/106084/s/682/
> Grid Page Before
>   http://git.reviewboard.kde.org/r/106084/s/683/
> Grid Page After
>   http://git.reviewboard.kde.org/r/106084/s/684/
> Misc Page Before
>   http://git.reviewboard.kde.org/r/106084/s/685/
> Misc Page After
>   http://git.reviewboard.kde.org/r/106084/s/686/
> Karbon Interface Page Before
>   http://git.reviewboard.kde.org/r/106084/s/687/
> Karbon Interface Page After
>   http://git.reviewboard.kde.org/r/106084/s/688/
> Sheets Open/Save Page Before
>   http://git.reviewboard.kde.org/r/106084/s/689/
> Sheets Open/Save Page After
>   http://git.reviewboard.kde.org/r/106084/s/690/
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120819/1b4ba711/attachment.htm>