<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106084/">http://git.reviewboard.kde.org/r/106084/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- C.</p>
<br />
<p>On August 19th, 2012, 11:16 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2012, 11:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QFormLayout slightly improves the look (&feel) of the dialogs.
The patch also aligns and changes the UI strings in the general config and the Sheet config to "Autosave interval:" and "Create backup file:"
Ideally Sheets would use the Documents page as well for consistency, but:
* it uses different config keys to store the data (could be solved by an update script though)
* not obvious where to put the "Number of entries in Recent Files list":
move to "Interface" page, like Karbon has it? Or turn "Document" page into "Load/Save" page?
Until that is decided, using QFormLayouts and consistent strings in the UI is an improvement already.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/sheets/configdialog.docbook <span style="color: grey">(ba78944)</span></li>
<li>doc/stage/options.docbook <span style="color: grey">(30b4275)</span></li>
<li>karbon/ui/widgets/KarbonConfigInterfacePage.cpp <span style="color: grey">(3bb0aae)</span></li>
<li>libs/main/config/KoConfigDocumentPage.cpp <span style="color: grey">(47a0905)</span></li>
<li>libs/main/config/KoConfigGridPage.cpp <span style="color: grey">(3b20a40)</span></li>
<li>libs/main/config/KoConfigMiscPage.cpp <span style="color: grey">(c0da74b)</span></li>
<li>sheets/part/dialogs/FileOptionsWidget.ui <span style="color: grey">(159cf95)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106084/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106084/s/681/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/DocumentPageBefore_400x100.png" style="border: 1px black solid;" alt="Document Settings Page Before" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/682/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/DocumentPageAfter_400x100.png" style="border: 1px black solid;" alt="Document Settings Page After" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/683/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/GridPageBefore_400x100.png" style="border: 1px black solid;" alt="Grid Page Before" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/684/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/GridPageAfter_400x100.png" style="border: 1px black solid;" alt="Grid Page After" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/685/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/MiscPageBefore_400x100.png" style="border: 1px black solid;" alt="Misc Page Before" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/686/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/MiscPageAfter_400x100.png" style="border: 1px black solid;" alt="Misc Page After" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/687/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/KarbonInterfacePageBefore_400x100.png" style="border: 1px black solid;" alt="Karbon Interface Page Before" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/688/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/KarbonInterfacePageAfter_400x100.png" style="border: 1px black solid;" alt="Karbon Interface Page After" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/689/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/SheetsOpenSavePageBefore_400x100.png" style="border: 1px black solid;" alt="Sheets Open/Save Page Before" /></a>
<a href="http://git.reviewboard.kde.org/r/106084/s/690/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/19/SheetsOpenSavePageAfter_400x100.png" style="border: 1px black solid;" alt="Sheets Open/Save Page After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>