Review Request: Fix misplaced validation tip in tableview; show invalid data warnings

Jarosław Staniek staniek at kde.org
Tue Aug 7 18:55:45 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105906/
-----------------------------------------------------------

(Updated Aug. 7, 2012, 5:55 p.m.)


Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.


Changes
-------

removed debug


Description
-------

Series of fixes for bugs causing possible data loss within data entry

Table View:
*Fixed misplaced 'Date/Time data error' validation popup in tableview
BUG:282295

*Show warning when invalid date values in tables and forms are rejected
BUG:299867

*Clicking validation popup editor is focus again allowing to correct the value
*Use new message widget for validation popups


This addresses bugs 282295 and 299867.
    http://bugs.kde.org/show_bug.cgi?id=282295
    http://bugs.kde.org/show_bug.cgi?id=299867


Diffs (updated)
-----

  kexi/kexiutils/kmessagewidget.h 4b01c63 
  kexi/kexiutils/kmessagewidget.cpp c5dbc9c 
  kexi/kexiutils/kmessagewidget_p.h e9386b7 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.h 1c70527 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 8295ba7 
  kexi/widget/tableview/kexidatetableedit.h 0bccd97 
  kexi/widget/tableview/kexidatetableedit.cpp 3721195 
  kexi/widget/tableview/kexidatetimetableedit.h 1fbc881 
  kexi/widget/tableview/kexidatetimetableedit.cpp 2b77b58 
  kexi/widget/tableview/kexitableview.h 079558b 
  kexi/widget/tableview/kexitableview.cpp 9d8be21 
  kexi/widget/tableview/kexitimetableedit.h e95228b 
  kexi/widget/tableview/kexitimetableedit.cpp 865928b 
  kexi/widget/utils/CMakeLists.txt cb57ce5 
  kexi/widget/utils/kexiarrowtip.h 3d9be8f 
  kexi/widget/utils/kexiarrowtip.cpp 0008a31 

Diff: http://git.reviewboard.kde.org/r/105906/diff/


Testing
-------

Invalid date/time types show warning properly in tables and forms


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120807/8c64e9cd/attachment.htm>


More information about the calligra-devel mailing list