Review Request: Fix misplaced validation tip in tableview; show invalid data warnings

Jarosław Staniek staniek at kde.org
Tue Aug 7 12:21:50 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105906/
-----------------------------------------------------------

Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.


Description
-------

Series of fixes for bugs causing possible data loss within data entry

Table View:
*Fixed misplaced 'Date/Time data error' validation popup in tableview
BUG:282295

*Show warning when invalid date values in tables and forms are rejected
BUG:299867

*Clicking validation popup editor is focus again allowing to correct the value
*Use new message widget for validation popups


This addresses bugs 282295 and 299867.
    http://bugs.kde.org/show_bug.cgi?id=282295
    http://bugs.kde.org/show_bug.cgi?id=299867


Diffs
-----

  kexi/kexiutils/kmessagewidget.h 4b01c63c40e8f105efb15ca2611ad9485859f8a5 
  kexi/kexiutils/kmessagewidget.cpp 371e3f628d20129e7fd5352e6c6f5521d0db2f85 
  kexi/kexiutils/kmessagewidget_p.h e9386b77c9fcfa58fc09764166d310188261f18f 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.h 1c70527b8bb394cc6c2b3b7af8bc4c3957c14b71 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 8295ba7e5f17b365a1c62a523c677aa0bc8473b1 
  kexi/widget/tableview/kexidatetableedit.h 0bccd974325df8d450e1fab79d53b6fe3fbe37b4 
  kexi/widget/tableview/kexidatetableedit.cpp 3721195c847ed3d654a91882c24fa54a82f6b8c9 
  kexi/widget/tableview/kexidatetimetableedit.h 1fbc881033b73fe1c6a9cfeff095452e9a07067a 
  kexi/widget/tableview/kexidatetimetableedit.cpp 2b77b58031e597cefb5891320d78180743dd39d0 
  kexi/widget/tableview/kexitableview.h 079558bfcf9f2e3eb76987c96ffb33bfc305d658 
  kexi/widget/tableview/kexitableview.cpp a74799e026a22522c7b0807d2ea458b71b4b997a 
  kexi/widget/tableview/kexitimetableedit.h e95228b3ed5dcd72c57e4ef859bf0f8a053bee21 
  kexi/widget/tableview/kexitimetableedit.cpp 865928bce2cc663e3bd482735d2c62e8795604b8 
  kexi/widget/utils/CMakeLists.txt cb57ce579246f20b6e90dbe3891e90a083700395 
  kexi/widget/utils/kexiarrowtip.h 3d9be8fc6894c98649e96194c0749fa60e41f450 
  kexi/widget/utils/kexiarrowtip.cpp 0008a31c633698b5d6ffd50121654da8ae262f35 

Diff: http://git.reviewboard.kde.org/r/105906/diff/


Testing
-------

Invalid date/time types show warning properly in tables and forms


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120807/8c20a43b/attachment.htm>


More information about the calligra-devel mailing list