Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104666/
-----------------------------------------------------------

(Updated April 19, 2012, 1:58 a.m.)


Review request for Calligra.


Changes
-------

And while I was at the ruler code, some more changes/fixes:
* remove no longer needed workaround to hide the tab chooser in KoReportDesigner.cpp
* on property changes in KoRuler only call update() if the property is shown, but call if shown
* remove unneededly doubled calls in KoRulerController.cpp


Description
-------

Currently in all programs (besides Words) the tab chooser is wrongly displayed somewhere on the horizontal ruler. And also if not needed, i.e. tabs are no property of the shape.

Attached patch fixes that:
* it puts the tab chooser in the corner for Stage and Karbon (so not for Krita, because less text oriented)
* it only creates the tab chooser on demand, not always (so it does not appear for Krita, like now)
* it only shows the tabs chooser if tabs are also shown in the ruler

(not sure that there should be no tab chooser for Krita)

Candidate for 2.4 backport?


Diffs (updated)
-----

  karbon/ui/KarbonView.cpp 2b9a907 
  libs/kopageapp/KoPAView.cpp fc28628 
  libs/koreport/wrtembed/KoReportDesigner.cpp 68a61f9 
  libs/main/KoRuler.cpp 4272b9b 
  libs/main/KoRulerController.cpp 39a2e3b 
  libs/main/KoRuler_p.h bfeac46 

Diff: http://git.reviewboard.kde.org/r/104666/diff/


Testing
-------

Started Krita, Karbon, Stage, Words and activated text shapes, had rulers shown and not shown.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120419/453de470/attachment.htm>