Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

Friedrich W. H. Kossebau kossebau at kde.org
Thu Apr 19 00:16:01 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104666/
-----------------------------------------------------------

(Updated April 19, 2012, 12:16 a.m.)


Review request for Calligra.


Changes
-------

forgot to ask whether Krita should have a tab chooser or not


Description (updated)
-------

Currently in all programs (besides Words) the tab chooser is wrongly displayed somewhere on the horizontal ruler. And also if not needed, i.e. tabs are no property of the shape.

Attached patch fixes that:
* it puts the tab chooser in the corner for Stage and Karbon (so not for Krita, because less text oriented)
* it only creates the tab chooser on demand, not always (so it does not appear for Krita, like now)
* it only shows the tabs chooser if tabs are also shown in the ruler

(not sure that there should be no tab chooser for Krita)

Candidate for 2.4 backport?


Diffs
-----

  karbon/ui/KarbonView.cpp 2b9a907 
  libs/kopageapp/KoPAView.cpp fc28628 
  libs/main/KoRuler.cpp 4272b9b 
  libs/main/KoRuler_p.h bfeac46 

Diff: http://git.reviewboard.kde.org/r/104666/diff/


Testing
-------

Started Krita, Karbon, Stage, Words and activated text shapes, had rulers shown and not shown.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120419/eafac428/attachment.html>


More information about the calligra-devel mailing list