please in the future push as one commit
Friedrich W. H. Kossebau
kossebau at kde.org
Tue Apr 17 17:25:18 BST 2012
Am Dienstag, 17. April 2012, 17:44:49 schrieb C. Boemann:
> On Tuesday 17 April 2012 17:42:45 Friedrich W. H. Kossebau wrote:
> > Am Dienstag, 17. April 2012, 17:34:00 schrieb C. Boemann:
> > > Please make sure that commits that don't work on their own is _never_
> > > commited on their own
> > >
> > > If someone checks out in between your commits now Calligra will not
> > > build. Which ruins any chance of using bisect.
> > >
> > > :(
> >
> > Hm, after any of these commits it compiled and worked for me (as I also
> > prefer it that way personally). Where does it break for you? Perhaps I
> > messed up on rebasing somewhere? :/
> >
> > And in the end that branch should be squashed into one commit anyway, or?
> > I
> > just pushed as multiple commits to help with review...
>
> yes sorry i though you commited to master , my bad
>
> you did good
How only could you assume otherwise, tss ;)
Cheers
Friedrich
More information about the calligra-devel
mailing list