please in the future push as one commit

C. Boemann cbo at boemann.dk
Tue Apr 17 16:44:49 BST 2012


On Tuesday 17 April 2012 17:42:45 Friedrich W. H. Kossebau wrote:
> Am Dienstag, 17. April 2012, 17:34:00 schrieb C. Boemann:
> > Please make sure that commits that don't work on their own is _never_
> > commited on their own
> > 
> > If someone checks out in between your commits now Calligra will not
> > build. Which ruins any chance of using bisect.
> > 
> > :(
> 
> Hm, after any of these commits it compiled and worked for me (as I also
> prefer it that way personally). Where does it break for you? Perhaps I
> messed up on rebasing somewhere? :/
> 
> And in the end that branch should be squashed into one commit anyway, or? I
> just pushed as multiple commits to help with review...
> 
> Cheers
> Friedrich
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
yes sorry i though you commited to master , my bad

you did good



More information about the calligra-devel mailing list