Review Request: Fix drawing of shadows for shapes

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104615/#review12546
-----------------------------------------------------------


I may not understand the problem fully, but it seems that not only does it paint the shadow too big but it also doesn't take the shadow into account when laying out out the text.  There is a method KoShape::boundingRect() whose documentation says: "This includes the line width and the shadow of the shape". Perhaps you are not using that or there is a bug in the implementation of it?


- Inge Wallin


On April 16, 2012, 2:03 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104615/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 2:03 p.m.)
> 
> 
> Review request for Calligra, Yue Liu, Jan Hambrecht, and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> There were a number of problems in the previous code that made shapes be cut off as can be seen in https://bugs.kde.org/show_bug.cgi?id=273500
> 
> This fixes that
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeShadow.cpp 431ee78 
> 
> Diff: http://git.reviewboard.kde.org/r/104615/diff/
> 
> 
> Testing
> -------
> 
> Tried shadows in all directions with and without blur. in Words (both anchored and non anchored), and in Stage
> 
> It appears to just work.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120416/18c97400/attachment.htm>