Review Request: Fix drawing of shadows for shapes

C. Boemann cbr at boemann.dk
Mon Apr 16 15:03:50 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104615/
-----------------------------------------------------------

(Updated April 16, 2012, 2:03 p.m.)


Review request for Calligra, Yue Liu, Jan Hambrecht, and Thorsten Zachmann.


Changes
-------

As per request from yue on irc, I now also take stroke widthinto consideration. Yay


Description
-------

There were a number of problems in the previous code that made shapes be cut off as can be seen in https://bugs.kde.org/show_bug.cgi?id=273500

This fixes that


Diffs (updated)
-----

  libs/flake/KoShapeShadow.cpp 431ee78 

Diff: http://git.reviewboard.kde.org/r/104615/diff/


Testing
-------

Tried shadows in all directions with and without blur. in Words (both anchored and non anchored), and in Stage

It appears to just work.


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120416/ebcdf5a8/attachment.htm>


More information about the calligra-devel mailing list