Review Request: in SnapGuideConfigWidget turn checkboxes to checkable buttons

Inge Wallin inge at lysator.liu.se
Sat Apr 7 06:35:36 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104483/#review12216
-----------------------------------------------------------

Ship it!


I didn't see anybody else answer this so I'll do it.  Yes, the 'after' looks much better.

Regarding 2.4, I would have liked it, but the tag of 2.4.0 is done now so that's too late. I'm not sure if we want to make a change like this to appear in 2.4.x (x>0) but if it came down to a vote I would vote 'yes'.

- Inge Wallin


On April 4, 2012, 2:50 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104483/
> -----------------------------------------------------------
> 
> (Updated April 4, 2012, 2:50 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Using toggable buttons with icons inside instead of checkboxes with icon next to it IMHO brings
> * less visual clutter
> * consistency with other icon-only state controls (e.g. text style or connection point)
> 
> See attached screenshots, with pointer tool dialog as example.
> (missing icon is "snap-boundingbox", not part of my OpenSuse oxygen-icon-theme 4.8.2-138.1 package, is that in Oxygen at all, is also listed at http://community.kde.org/Calligra/Icons as missing)
> 
> Want in 2.4 as well?
> 
> 
> Diffs
> -----
> 
>   libs/flake/SnapGuideConfigWidget.h 043fdb4 
>   libs/flake/SnapGuideConfigWidget.cpp 8784f3c 
>   libs/flake/SnapGuideConfigWidget.ui 487105e 
> 
> Diff: http://git.reviewboard.kde.org/r/104483/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/104483/s/504/
> After
>   http://git.reviewboard.kde.org/r/104483/s/505/
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120407/3c3e5092/attachment-0001.html>


More information about the calligra-devel mailing list