Review Request: in SnapGuideConfigWidget turn checkboxes to checkable buttons

Friedrich W. H. Kossebau kossebau at kde.org
Wed Apr 4 15:50:03 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104483/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Using toggable buttons with icons inside instead of checkboxes with icon next to it IMHO brings
* less visual clutter
* consistency with other icon-only state controls (e.g. text style or connection point)

See attached screenshots, with pointer tool dialog as example.
(missing icon is "snap-boundingbox", not part of my OpenSuse oxygen-icon-theme 4.8.2-138.1 package, is that in Oxygen at all, is also listed at http://community.kde.org/Calligra/Icons as missing)

Want in 2.4 as well?


Diffs
-----

  libs/flake/SnapGuideConfigWidget.h 043fdb4 
  libs/flake/SnapGuideConfigWidget.cpp 8784f3c 
  libs/flake/SnapGuideConfigWidget.ui 487105e 

Diff: http://git.reviewboard.kde.org/r/104483/diff/


Testing
-------


Screenshots
-----------

Before
  http://git.reviewboard.kde.org/r/104483/s/504/
After
  http://git.reviewboard.kde.org/r/104483/s/505/


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120404/25557ad3/attachment.htm>


More information about the calligra-devel mailing list