Review Request: Add frame preview support (aka PNG/SVG Previews)

[Jan Hambrecht]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6566
-----------------------------------------------------------



libs/flake/KoShapeRegistry.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5806>

    I am not sure the logic explained here is what we want. There might be another shape which can load the second representation of the frame content. I think the unavailable shape should be the very last resort, i.e. if none of all the different representations of the frame content could be loaded by any other shape.
    Or do I miss something here?



libs/flake/KoShapeRegistry.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5802>

    Excessive whitespace, please remove.



libs/flake/KoShapeRegistry.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5803>

    Excessive whitespace, please remove.



libs/flake/KoShapeRegistry.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5804>

    please add {} braces here.



libs/flake/KoShapeRegistry.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5805>

    This #else block is still there, please remove.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5807>

    There is no matching restore call, however i think is can be removed.


- Jan


On Sept. 15, 2011, 3:05 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 3:05 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110916/c45134c2/attachment.htm>