Review Request: Add frame preview support (aka PNG/SVG Previews)

[Sebastian Sauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6542
-----------------------------------------------------------



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5788>

    Maybe it should be something like
    
    QString("ObjectReplacements/%1%2").arg(newName).arg(lap-1)
    
    so we get
    
    ObjectReplacements/Object1
    ObjectReplacements/Object1-2
    ObjectReplacements/Object1-3
    etc.
    
    what sounds more logical then appending _ characters imho.
    



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5789>

    Just nitpicking; loadFile+saveFile sounds more logical then loadFile+storeFile for me. I am not aware of other code in Calligra which uses storeFile/storeObject. It took us long to get right of the writeFile/saveFile mix so maybe we should continue to use saveFile and not storeFile? Well, that would make the patch smaller at least :) But that's only imho / my 2 cent / personal opinion and not really important.
    


- Sebastian


On Sept. 15, 2011, 3:05 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 3:05 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110915/9a419fdd/attachment.htm>