Review Request: Add frame preview support (aka PNG/SVG Previews)
Dan Leinir Turthra Jensen
admin at leinir.dk
Thu Sep 15 09:36:36 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/
-----------------------------------------------------------
(Updated Sept. 15, 2011, 8:36 a.m.)
Review request for Calligra.
Changes
-------
1. Attempted to fix background issue
2. Lost image issue is is an unrelated bug (both slides are rendered wrongly, just wrong in a different way, and such this really shouldn't be blocking this patch - see https://bugs.kde.org/show_bug.cgi?id=281932 )
3. Not attempted to fix this - will discuss on IRC
Also, whitespace fixes throughout and privated some functions which should be private (suggested by Jan)
Summary
-------
Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
Work done by Inge Wallin and Dan Leinir Turthra Jensen.
Diffs (updated)
-----
libs/flake/KoShapeRegistry.cpp a65b1c9
libs/flake/KoUnavailShape.h fb346f7
libs/flake/KoUnavailShape.cpp c9bfc77
Diff: http://git.reviewboard.kde.org/r/102512/diff
Testing
-------
compiled, run and functionality tested by ingwa
Thanks,
Dan Leinir Turthra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110915/9cff437f/attachment.htm>
More information about the calligra-devel
mailing list