Review Request: Add frame preview support (aka PNG/SVG Previews)

[Dan Leinir Turthra Jensen]

> On Sept. 2, 2011, 7:53 p.m., Jan Hambrecht wrote:
> > libs/flake/KoShapeRegistry.cpp, lines 241-247
> > <http://git.reviewboard.kde.org/r/102512/diff/3/?file=33369#file33369line241>
> >
> >     I suppose this part can be removed now.
> 
> Dan Leinir Turthra Jensen wrote:
>     i'm not entirely sure i understand what you mean by this comment... Do you mean, you agree that this comment can be removed? Or do you mean that you think this particular block of changes should be removed from the patch? :)
> 
> Jan Hambrecht wrote:
>     I marked the complete #else block, not sure if reviewborard is displaying that correctly. If I understand you replace/extend the part of the code which is now in the #else block. If that is the case I think you should remove the old code and just leave the new code in place. Keeping obsolete code in an #if #else block just clutters the code.

Ah! i see it now. Yes, you did indeed grab the entire else block, i just seem to have mentally blocked it and just looked at the red block ;) Yes, i see what you mean now, well spotted too :)


- Dan Leinir Turthra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6246
-----------------------------------------------------------


On Sept. 2, 2011, 11:24 a.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2011, 11:24 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110905/ee1a2450/attachment.htm>