Review Request: Added Footnotes/Endnotes in References Tool

[Thorsten Zachmann]

> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/textlayout/KoTextLayoutEndNotesArea.cpp, line 128
> > <http://git.reviewboard.kde.org/r/102552/diff/2/?file=35556#file35556line128>
> >
> >     Maybe you can somewhere define what all these numbers are for
> 
> Brijesh Patel wrote:
>     when we were doing  painter->drawLine(left(), top(), right(), top());
>     the divider line was not looking elegant since it covers the whole space from left to right in the doc and also very much sticking to the normal text of the document above the line.
>     
>     so give proper spacing and increase the elegance,i reduced the width of the line and shifted it somewhat below than it was before.

What I meant by to comment is that the numbers are not clear for the reader of the code to see what they are doing. If you have some consts with a clear name which define them it is much easier for the reader to understand what is going one.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6323
-----------------------------------------------------------


On Sept. 8, 2011, 3:28 p.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 3:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextEditor.h ba28354 
>   libs/kotext/KoTextEditor.cpp 4d3e5b18 
>   libs/kotext/opendocument/KoTextLoader.cpp e9d47da 
>   libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 5a8324e 
>   libs/textlayout/KoTextLayoutArea.h ea7fd8e 
>   libs/textlayout/KoTextLayoutArea.cpp 504de0c 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h 40676b2 
>   plugins/textshape/ReferencesTool.cpp 0bbd38d 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110909/1924b5b3/attachment.htm>