Review Request: Added Footnotes/Endnotes in References Tool

[Thorsten Zachmann]

> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/kotext/KoInlineNote.cpp, lines 164-165
> > <http://git.reviewboard.kde.org/r/102552/diff/2/?file=35543#file35543line164>
> >
> >     Maybe you can remove the count variable and do the renumbering where a new footnote is added to the inline object manager. Then you will be sure it works correctly also when there are more then one document.
> 
> Brijesh Patel wrote:
>     that poses a problem when the footnotes are deleted...

I had a look at the KoInlineTextObjectManager and I think this code belongs to be in there. There is also a function that gets called when an inline object gets deleted so I think that should work. Doing the whole stuff at painting time is not the right thing to do


> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/kotext/KoInlineNote.cpp, line 233
> > <http://git.reviewboard.kde.org/r/102552/diff/2/?file=35543#file35543line233>
> >
> >     Is there a reason to remove this line here. I think it only makes sure that the initial value of the variable is set correctly.
> 
> Brijesh Patel wrote:
>     I dont remember the reason exactly why i removed,
>     but it was something like this
>     the notes which are inserted in this session only get the autonumbering tag while loading,but previously inserted notes don't.
>     so counting begins from 1 in each session.
>

Can you please check if the line is realy needed.


> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/kotext/KoInlineNote.cpp, lines 286-290
> > <http://git.reviewboard.kde.org/r/102552/diff/2/?file=35543#file35543line286>
> >
> >     The notes configuration should be saved only once and not with each footnote. Please ping me on IRC if you have a question on how that can be done.
> 
> Brijesh Patel wrote:
>     I am doing a check for that only,
>     see line 283: if (KoTextDocument(d->textFrame->document()).inlineTextObjectManager()->getFirstNote(d->textFrame->document()->begin())->id() == this-   
>                   >id()) {
>     
>     it will go inside "if" only if it is the first visible note of the document otherwise it wont go

As the KoOdfNotesConfiguration is used as a style and handled like that in loading I think it would be better if the KoStyleManager would be resposible about it. But maybe others see it differently. If it would be part of the KoStyleManager it could be loaded and saved like all othere styles in one.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6323
-----------------------------------------------------------


On Sept. 8, 2011, 3:28 p.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 3:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextEditor.h ba28354 
>   libs/kotext/KoTextEditor.cpp 4d3e5b18 
>   libs/kotext/opendocument/KoTextLoader.cpp e9d47da 
>   libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 5a8324e 
>   libs/textlayout/KoTextLayoutArea.h ea7fd8e 
>   libs/textlayout/KoTextLayoutArea.cpp 504de0c 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h 40676b2 
>   plugins/textshape/ReferencesTool.cpp 0bbd38d 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110909/3701423f/attachment.htm>