Review Request: Add frame preview support (aka PNG/SVG Previews)

[Thorsten Zachmann]

> On Sept. 2, 2011, 1:06 p.m., Thorsten Zachmann wrote:
> > I have run cstester on all the documents and found various problems:
> > 
> > - Wrong background 
> >   seems to has something to do with adding a default background in calligra
> > - image lost
> > - embedded charts graphic no longer antialiazed
> > 
> > I have uploaded some of the files to 
> > 
> > http://www.zagge.de/anchor/unavail/
> > 
> > info.txt contains details about the found problems
> > a contains the thumbnails without the patch
> > b contains the thumbnails with the patch
> > 
> >
> 
> Dan Leinir Turthra Jensen wrote:
>     Having hammered my head against this particular wall for too long for my own liking, have you got any ideas for where i should be looking for these problems? :)

- Wrong background 
  seems to has something to do with adding a default background in calligra

This might be related to KoOdfWorkaround::fixBackgroundColor

- image lost

No idea

- embedded charts graphic no longer antialiazed

maybe checking the value of painter.testRenderHint(QPainter::Antialiasing) when painting a problematic shape and see if it is off. and then try to find out where it gets switched off.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6238
-----------------------------------------------------------


On Sept. 2, 2011, 11:24 a.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2011, 11:24 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110908/24945b31/attachment.htm>