Review Request: Add frame preview support (aka PNG/SVG Previews)

[Jan Hambrecht]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6246
-----------------------------------------------------------



libs/flake/KoShapeRegistry.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5499>

    I suppose this part can be removed now.



libs/flake/KoShapeRegistry.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5500>

    I think this line is not required. If shape is not zero, we would have returned it already.



libs/flake/KoUnavailShape.h
<http://git.reviewboard.kde.org/r/102512/#comment5501>

    Please watch your whitespace usage. There are more of these later on.



libs/flake/KoUnavailShape.h
<http://git.reviewboard.kde.org/r/102512/#comment5502>

    Why not put these into the private class?


- Jan


On Sept. 2, 2011, 11:24 a.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2011, 11:24 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110902/5ad61cb7/attachment.htm>