Review Request: Implement Delete Style in the style manager

Inge Wallin inge at lysator.liu.se
Wed Oct 26 19:30:56 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102863/
-----------------------------------------------------------

(Updated Oct. 26, 2011, 6:30 p.m.)


Review request for Calligra.


Changes
-------

New update from Moji.  When I tested it, it seems that the issues are fixed. What have I missed?


Description
-------

This patch is from Mojtaba Shahi Senobari, and implements deletion of styles in the style manager. The tricky part is that if the deleted is used by some paragraph they have to be assigned another paragraph.

This is Moji's first patch here at the reviewboard.  Be gentle. :)


Diffs (updated)
-----

  libs/kotext/styles/KoParagraphStyle.h 3f9f40c 
  libs/kotext/styles/KoParagraphStyle.cpp cdf16a4 
  libs/kotext/styles/KoStyleManager.h ac145f9 
  libs/kotext/styles/KoStyleManager.cpp fbbc4ee 
  plugins/textshape/CMakeLists.txt 52fd060 
  plugins/textshape/dialogs/StyleManager.h 93247b7 
  plugins/textshape/dialogs/StyleManager.cpp 99ed8b8 
  plugins/textshape/dialogs/StylesWidget.h 844bed8 
  plugins/textshape/dialogs/StylesWidget.cpp 4f31a01 

Diff: http://git.reviewboard.kde.org/r/102863/diff/diff


Testing
-------

I tested with a number of combinations of paragraph styles, and it seems to work.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111026/192b9997/attachment.htm>


More information about the calligra-devel mailing list