Review Request: Implement Delete Style in the style manager
C. Boemann
cbr at boemann.dk
Fri Oct 14 18:32:11 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102863/#review7340
-----------------------------------------------------------
It seems you delete the style immediately and not on ok/apply like other changes.
So what you need is a list of deletedParagraphs and then do the changes on ok/apply
plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/102863/#comment6413>
ah i see you use the m_DeletedParagraphStyle here
plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/102863/#comment6412>
Ah yes it's deleted here, so never mind about that
- C. Boemann
On Oct. 14, 2011, 4:40 p.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102863/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2011, 4:40 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> This patch is from Mojtaba Shahi Senobari, and implements deletion of styles in the style manager. The tricky part is that if the deleted is used by some paragraph they have to be assigned another paragraph.
>
> This is Moji's first patch here at the reviewboard. Be gentle. :)
>
>
> Diffs
> -----
>
> libs/kotext/styles/KoStyleManager.h ac145f9
> libs/kotext/styles/KoStyleManager.cpp fbbc4ee
> plugins/textshape/dialogs/StyleManager.h 93247b7
> plugins/textshape/dialogs/StyleManager.cpp 99ed8b8
>
> Diff: http://git.reviewboard.kde.org/r/102863/diff/diff
>
>
> Testing
> -------
>
> I tested with a number of combinations of paragraph styles, and it seems to work.
>
>
> Thanks,
>
> Inge Wallin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111014/7ec3447a/attachment.htm>
More information about the calligra-devel
mailing list