Review Request: New UI for words, some hopefully insignificat changes to other apps

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102871/#review7367
-----------------------------------------------------------


My biggest concern is about constiency between the different applications changes with this patch. Would it not be better if that would be a common option the user can select so all applications would behave like that?


karbon/plugins/tools/KarbonGradientToolFactory.cpp
<http://git.reviewboard.kde.org/r/102871/#comment6436>

    Do I understand correctly that setting the type to karbon let the tools still be available in stage but in a different area in the toolbox?


- Thorsten Zachmann


On Oct. 15, 2011, 4:49 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102871/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2011, 4:49 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This UI was conceived during the KDE User Experience sprint in Berlin 2011
> 
> It basically provides a drop-in-replacement for the toolbox + tooloptionsdocker in the form of a single docker containing QToolBox widget.
> 
> The new KoModeBox is used in Words only. All the other applications should be left unchanged.
> 
> The tools have a new extended usage of the Type attribute. See the KoToolFactoryBase.h changes for description. It should be compatible with the krita usage.
> The only visible changes outside Words would probably be that the gradient, pattern,calligraphy tools end up in a separate section of the toolbox.
> 
> 
> Diffs
> -----
> 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp cb1c092 
>   karbon/plugins/tools/KarbonGradientToolFactory.cpp 786d98a 
>   karbon/plugins/tools/KarbonPatternToolFactory.cpp 1ec250fa 
>   karbon/plugins/tools/KarbonPencilToolFactory.cpp 4fd1105 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp c30f1be 
>   libs/flake/KoToolFactoryBase.h 73f2534 
>   libs/flake/KoToolManager.cpp 3bcae08 
>   libs/main/CMakeLists.txt 9539a5a 
>   libs/main/KoDockerManager.h 7e44455 
>   libs/main/KoDockerManager.cpp 7f5b17d 
>   libs/main/KoModeBox.cpp PRE-CREATION 
>   libs/main/KoModeBoxFactory.h PRE-CREATION 
>   libs/main/KoModeBoxFactory.cpp PRE-CREATION 
>   libs/main/KoModeBox_p.h PRE-CREATION 
>   libs/main/KoToolBox.cpp ede46d4 
>   plugins/textshape/ReferencesToolFactory.cpp 096e602 
>   plugins/textshape/ReviewToolFactory.cpp bbd6452 
>   plugins/textshape/TextToolFactory.cpp 438846c 
>   words/part/KWGui.cpp 69d309b 
> 
> Diff: http://git.reviewboard.kde.org/r/102871/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> screentshot of the new ui
>   http://git.reviewboard.kde.org/r/102871/s/306/
> toolbox in karbon
>   http://git.reviewboard.kde.org/r/102871/s/307/
> toolbox in krita
>   http://git.reviewboard.kde.org/r/102871/s/308/
> toolbox in stage
>   http://git.reviewboard.kde.org/r/102871/s/309/
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111016/bd725459/attachment.htm>