Review Request: Continue refactoring of Kotext/styles/KoTableBorderStyle and KoBorder

C. Boemann cbr at boemann.dk
Wed Oct 12 20:57:46 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102724/#review7279
-----------------------------------------------------------

Ship it!


just a few cosmetic issues and you can commit


libs/kotext/KoTextEditor.cpp
<http://git.reviewboard.kde.org/r/102724/#comment6368>

    spaces



libs/odf/KoBorder.h
<http://git.reviewboard.kde.org/r/102724/#comment6369>

    spaces



libs/odf/KoBorder.h
<http://git.reviewboard.kde.org/r/102724/#comment6370>

    spaces



libs/odf/KoBorder.h
<http://git.reviewboard.kde.org/r/102724/#comment6371>

    spaces



libs/odf/KoBorder.h
<http://git.reviewboard.kde.org/r/102724/#comment6372>

    spaces


- C. Boemann


On Oct. 11, 2011, 11:25 p.m., Pierre Ducroquet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102724/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2011, 11:25 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch removes almost everything that was left in KoTableBorderStyle and uses only KoBorder instead.
> 
> 
> Diffs
> -----
> 
>   filters/libmsooxml/MsooXmlDrawingTableStyleReader.cpp 86f07b1 
>   filters/libmsooxml/MsooXmlTableStyle.cpp 5f1de19 
>   filters/words/docx/DocxXmlDocumentReader.cpp 18f43fb 
>   filters/words/docx/DocxXmlStylesReader.cpp c859eca 
>   libs/kotext/KoTextEditor.cpp 11d6df7 
>   libs/kotext/styles/KoTableBorderStyle.h 6c24a75 
>   libs/kotext/styles/KoTableCellStyle.h 3d3379b 
>   libs/kotext/styles/KoTableCellStyle.cpp 1b6876c 
>   libs/odf/KoBorder.h 83cdac8 
>   libs/odf/KoBorder.cpp 1161a0a 
>   libs/textlayout/KoTextLayoutCellHelper.cpp 7d0dfd7 
>   words/part/KWCanvasBase.cpp fb7fc2c 
> 
> Diff: http://git.reviewboard.kde.org/r/102724/diff/diff
> 
> 
> Testing
> -------
> 
> Compiling, running kotext unit tests.
> 
> 
> Thanks,
> 
> Pierre Ducroquet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111012/782325dd/attachment.htm>


More information about the calligra-devel mailing list