Review Request: Add markers (arrows and other stuff put at the end of a line)

Thorsten Zachmann t.zachmann at zagge.de
Wed Nov 16 05:51:26 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103152/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

At the sprint it was suggested to have this feature/bug fix in 2.4. Therefore positing for review. It adds one new string.

This add support for markers to calligra. 

Loading, saving, manipulation, work without problems

At the moment the document loaded need to have markers so that the user can select a marker on a path shape. I'm working on adding markers per default to the docker at the moment.


This addresses bugs 260421, 260423 and 260431.
    http://bugs.kde.org/show_bug.cgi?id=260421
    http://bugs.kde.org/show_bug.cgi?id=260423
    http://bugs.kde.org/show_bug.cgi?id=260431


Diffs
-----

  libs/flake/CMakeLists.txt 5face45 
  libs/flake/KoDocumentResourceManager.h 2d6c8c0 
  libs/flake/KoLineBorder.h 7f7d088 
  libs/flake/KoLineBorder.cpp a2f0645 
  libs/flake/KoMarker.h PRE-CREATION 
  libs/flake/KoMarker.cpp PRE-CREATION 
  libs/flake/KoMarkerCollection.h PRE-CREATION 
  libs/flake/KoMarkerCollection.cpp PRE-CREATION 
  libs/flake/KoMarkerData.h PRE-CREATION 
  libs/flake/KoMarkerData.cpp PRE-CREATION 
  libs/flake/KoMarkerSharedLoadingData.h PRE-CREATION 
  libs/flake/KoMarkerSharedLoadingData.cpp PRE-CREATION 
  libs/flake/KoPathShape.h 5b5b91b 
  libs/flake/KoPathShape.cpp 1898862 
  libs/flake/KoPathShapeFactory.cpp f3a98b8 
  libs/flake/KoPathShape_p.h e1e2843 
  libs/flake/KoShapeLoadingContext.cpp 9d3d1da 
  libs/flake/KoShapeSavingContext.h a06e040 
  libs/flake/KoShapeSavingContext.cpp 34f55c8 
  libs/flake/commands/KoPathShapeMarkerCommand.h PRE-CREATION 
  libs/flake/commands/KoPathShapeMarkerCommand.cpp PRE-CREATION 
  libs/widgets/CMakeLists.txt 473a264 
  libs/widgets/KoMarkerItemDelegate.h PRE-CREATION 
  libs/widgets/KoMarkerItemDelegate.cpp PRE-CREATION 
  libs/widgets/KoMarkerModel.h PRE-CREATION 
  libs/widgets/KoMarkerModel.cpp PRE-CREATION 
  libs/widgets/KoMarkerSelector.h PRE-CREATION 
  libs/widgets/KoMarkerSelector.cpp PRE-CREATION 
  libs/widgets/KoStrokeConfigWidget.h 3ae44b9 
  libs/widgets/KoStrokeConfigWidget.cpp 9b2532f 
  marker_todo.txt PRE-CREATION 
  plugins/dockers/strokedocker/StrokeDocker.h dde8db7 
  plugins/dockers/strokedocker/StrokeDocker.cpp 82f18b5 

Diff: http://git.reviewboard.kde.org/r/103152/diff/diff


Testing
-------

Tested various documents with markers and they all worked without problems. Tested manipulation of path shapes that have a marker attached.


Thanks,

Thorsten Zachmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111116/67768884/attachment.html>


More information about the calligra-devel mailing list