<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103152/">http://git.reviewboard.kde.org/r/103152/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Thorsten Zachmann.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At the sprint it was suggested to have this feature/bug fix in 2.4. Therefore positing for review. It adds one new string.
This add support for markers to calligra.
Loading, saving, manipulation, work without problems
At the moment the document loaded need to have markers so that the user can select a marker on a path shape. I'm working on adding markers per default to the docker at the moment.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested various documents with markers and they all worked without problems. Tested manipulation of path shapes that have a marker attached.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260421">260421</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=260423">260423</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=260431">260431</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/CMakeLists.txt <span style="color: grey">(5face45)</span></li>
<li>libs/flake/KoDocumentResourceManager.h <span style="color: grey">(2d6c8c0)</span></li>
<li>libs/flake/KoLineBorder.h <span style="color: grey">(7f7d088)</span></li>
<li>libs/flake/KoLineBorder.cpp <span style="color: grey">(a2f0645)</span></li>
<li>libs/flake/KoMarker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoMarker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoMarkerCollection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoMarkerCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoMarkerData.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoMarkerData.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoMarkerSharedLoadingData.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoMarkerSharedLoadingData.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoPathShape.h <span style="color: grey">(5b5b91b)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(1898862)</span></li>
<li>libs/flake/KoPathShapeFactory.cpp <span style="color: grey">(f3a98b8)</span></li>
<li>libs/flake/KoPathShape_p.h <span style="color: grey">(e1e2843)</span></li>
<li>libs/flake/KoShapeLoadingContext.cpp <span style="color: grey">(9d3d1da)</span></li>
<li>libs/flake/KoShapeSavingContext.h <span style="color: grey">(a06e040)</span></li>
<li>libs/flake/KoShapeSavingContext.cpp <span style="color: grey">(34f55c8)</span></li>
<li>libs/flake/commands/KoPathShapeMarkerCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/commands/KoPathShapeMarkerCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(473a264)</span></li>
<li>libs/widgets/KoMarkerItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoMarkerItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoMarkerModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoMarkerModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoMarkerSelector.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoMarkerSelector.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: grey">(3ae44b9)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: grey">(9b2532f)</span></li>
<li>marker_todo.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/dockers/strokedocker/StrokeDocker.h <span style="color: grey">(dde8db7)</span></li>
<li>plugins/dockers/strokedocker/StrokeDocker.cpp <span style="color: grey">(82f18b5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103152/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>