Patch: Remove some deprecated functions

Boudewijn Rempt boud at valdyas.org
Mon Nov 7 09:17:53 GMT 2011


On Saturday 05 November 2011 Nov, Mauro wrote:
>   Hi everyone,
> 
> while building calligra I have noticed many compiler warning related to
> the use of deprecated functions. I have tried to remove as many as
> possible among the most trivial (dates/locale functions).
> 
> While browsing the code I also came upon this strange if construct:
> 
> [filters/words/rtf/import/rtf-qt/src/UserPropsDestination.cpp]
> 38  if ( value == 30 ) {
> 39    m_propertyType = QVariant::String;
> 40  } else if ( value == 3 ) {
> 41    m_propertyType == QVariant::Int; // <-- statement with no effect
> 42  } else if ( value == 5 ) {
> 43    m_propertyType == QVariant::Double; // again, no effect
>     } ........... {
> 49    qDebug() << "unhandled value type in UserPropsDestination:" << value;
> 50  }

This is a tricky bit: the rtf-qt library is actually third-party code by brad hards, included in calligra because we needed it and it's not in any distribution yet. By now, Brad has a new version that's much better, and I should update our version to his latest version.

> 
> I assumed that the idea was to *set* the m_propertyType field (as in row
> 39), so I have also fixed that in my patch.
> 
> On IRC boemann told me to post the patch here and to take this
> opportunity to introduce briefly myself to the community. So... My name
> is Mauro and I am a MSc student of Computer Engineering at PoliTO.
> 
> I know this is a patch of little value, but I hope to be able to do more
> in the future.
> Maybe some Junior Jobs...
> 
> Best,
> 
> 


-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl



More information about the calligra-devel mailing list