Review Request: Kotext, cell styles, support for text properties
Pierre Ducroquet
pinaraf at gmail.com
Tue May 3 23:17:01 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101281/#review3092
-----------------------------------------------------------
Hi
Nice work, but I've got two questions :
- where is that defined in the OpenDocument specification ? I can not find it, and it was never reported by the automated unit tests...
- did you check whether the tests still compiled ?
Thanks
- Pierre
On May 3, 2011, 11:37 a.m., Lassi Taneli Nieminen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101281/
> -----------------------------------------------------------
>
> (Updated May 3, 2011, 11:37 a.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> Odf allows text properties for cell-styles, previous kotext did not support this.
> This patch adds support for that.
>
>
> Diffs
> -----
>
> libs/kotext/opendocument/KoTextSharedLoadingData.h 0348049
> libs/kotext/opendocument/KoTextSharedLoadingData.cpp 532c752
> libs/kotext/styles/KoTableCellStyle.h 89e3862
> libs/kotext/styles/KoTableCellStyle.cpp ecae702
> libs/kotext/styles/KoTableCellStyle_p.h 15f4dfe
>
> Diff: http://git.reviewboard.kde.org/r/101281/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lassi Taneli
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110503/df5681a2/attachment.htm>
More information about the calligra-devel
mailing list