Review Request: Kotext, cell styles, support for text properties

Jarosław Staniek staniek at kde.org
Tue May 3 20:14:10 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101281/#review3090
-----------------------------------------------------------



libs/kotext/styles/KoTableCellStyle.h
<http://git.reviewboard.kde.org/r/101281/#comment2628>

    Let's use @return and finish the sentence with.
    
    Also, let's use comment convention, i.e.
    /*
     *
     */


- Jarosław


On May 3, 2011, 11:37 a.m., Lassi Taneli Nieminen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101281/
> -----------------------------------------------------------
> 
> (Updated May 3, 2011, 11:37 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Odf allows text properties for cell-styles, previous kotext did not support this.
> This patch adds support for that.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/opendocument/KoTextSharedLoadingData.h 0348049 
>   libs/kotext/opendocument/KoTextSharedLoadingData.cpp 532c752 
>   libs/kotext/styles/KoTableCellStyle.h 89e3862 
>   libs/kotext/styles/KoTableCellStyle.cpp ecae702 
>   libs/kotext/styles/KoTableCellStyle_p.h 15f4dfe 
> 
> Diff: http://git.reviewboard.kde.org/r/101281/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lassi Taneli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110503/61f0a7e9/attachment.htm>


More information about the calligra-devel mailing list