breaking unittests is BAD

Boudewijn Rempt boud at valdyas.org
Tue Mar 8 05:22:33 GMT 2011


On Monday 07 March 2011, C. Boemann wrote:
> On Monday 07 March 2011 06:40:15 Boudewijn Rempt wrote:
> > Hi,
> > 
> > _If_ we want to be able to release master as a reasonably stable snapshot,
> > we really have to be better about our unittests. Even if the unittests
> > test something that is being refactored anyway in a branch, we should
> > _NOT_ break those tests.
> > 
> > 
> > Currently we have the following failures:
> > 
> >           7 - words-part-frame-TestDocumentLayout (Failed)
> > 
> > This one is a crash after a refactoring by Sebastian, and when I remove the
> > cause for the crash, the test fails completely anyway.
> 
> I wouldn't mind if we just deleted that file. There is nothing in there that is 
> worth salvaging.

Well, you're the maintainer, so you can remove a test that you think is useless :-)

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org



More information about the calligra-devel mailing list