breaking unittests is BAD
Boudewijn Rempt
boud at valdyas.org
Tue Mar 8 05:22:14 GMT 2011
On Monday 07 March 2011, Arjen Hiemstra wrote:
> On Monday 07 March 2011 06:40:15 Boudewijn Rempt wrote:
> > 183 - libs-widgets-zoomhandler_test (Failed)
> >
> > Arjen: you were going to fix this test -- please do that today!
> >
>
> Yeah, I fixed it today though I'm not entirely happy with the solution. There
> is a zoomcontroller_test where I wanted to move the test but it turns out that
> contains no code and crashes as soon as I want to add something due to
> KoCanvasControllerWidget not having a proper canvas to control. I will need to
> do some more investigating into that as it really should be properly tested.
Ok... Just mull it over. It's important to have good tests, but good testing takes some thinking :-).
--
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org
More information about the calligra-devel
mailing list