Review Request: Support added for filter loading in another process

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101794/#review4251
-----------------------------------------------------------


Some preliminary notes -- not a real review yet...

* this only works for filters that convert from file to file, so the tables excel filter and the krita filters cannot make use of it.
* I'm not sure about the naming for things like setAsynchronousLoading -- that probably should be setOutOfProcessLoading, and the new classes, but for those I need to think a bit.
* there is something weird with the progress updating, but that might also have been the case beforehand. the 900kb document shows 6 and 70 percent progress, and nothing in between or afterwards.

- Boudewijn


On June 28, 2011, 12:46 p.m., Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101794/
> -----------------------------------------------------------
> 
> (Updated June 28, 2011, 12:46 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> It can happen that filters crash the application while loading invalid file.
> Because the fixing would be to costly I have created this work around.
> 
> The idea is to place the loading code into another process and if the filter crashes the main application stays alive.
> 
> 
> Diffs
> -----
> 
>   libs/main/CMakeLists.txt 5492748 
>   libs/main/KoDocument.h 1cd759f 
>   libs/main/KoDocument.cpp 7c2d8e3 
>   libs/main/KoFilterChainLink.cpp 628ff95 
>   libs/main/KoFilterManager.h 5e05b3b 
>   libs/main/KoFilterManager.cpp d4bc313 
>   libs/main/KoFilterManager_p.h f7a4485 
>   libs/main/KoUpdater.h f6406c3 
>   libs/main/KoUpdater.cpp 484d7e4 
>   libs/main/KoUpdaterPrivate_p.cpp eae2e54 
>   libs/main/OutOfProcessLoad/CMakeLists.txt PRE-CREATION 
>   libs/main/OutOfProcessLoad/KoFilterLoader.h PRE-CREATION 
>   libs/main/OutOfProcessLoad/KoFilterLoader.cpp PRE-CREATION 
>   libs/main/OutOfProcessLoad/KoOutOfProcessLoad.h PRE-CREATION 
>   libs/main/OutOfProcessLoad/KoOutOfProcessLoad.cpp PRE-CREATION 
>   libs/main/OutOfProcessLoad/main.cpp PRE-CREATION 
>   words/part/KWDocument.cpp 77fb02f 
> 
> Diff: http://git.reviewboard.kde.org/r/101794/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110629/9a4ff878/attachment.htm>