<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101794/">http://git.reviewboard.kde.org/r/101794/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some preliminary notes -- not a real review yet...
* this only works for filters that convert from file to file, so the tables excel filter and the krita filters cannot make use of it.
* I'm not sure about the naming for things like setAsynchronousLoading -- that probably should be setOutOfProcessLoading, and the new classes, but for those I need to think a bit.
* there is something weird with the progress updating, but that might also have been the case beforehand. the 900kb document shows 6 and 70 percent progress, and nothing in between or afterwards.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On June 28th, 2011, 12:46 p.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated June 28, 2011, 12:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It can happen that filters crash the application while loading invalid file.
Because the fixing would be to costly I have created this work around.
The idea is to place the loading code into another process and if the filter crashes the main application stays alive.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/CMakeLists.txt <span style="color: grey">(5492748)</span></li>
<li>libs/main/KoDocument.h <span style="color: grey">(1cd759f)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(7c2d8e3)</span></li>
<li>libs/main/KoFilterChainLink.cpp <span style="color: grey">(628ff95)</span></li>
<li>libs/main/KoFilterManager.h <span style="color: grey">(5e05b3b)</span></li>
<li>libs/main/KoFilterManager.cpp <span style="color: grey">(d4bc313)</span></li>
<li>libs/main/KoFilterManager_p.h <span style="color: grey">(f7a4485)</span></li>
<li>libs/main/KoUpdater.h <span style="color: grey">(f6406c3)</span></li>
<li>libs/main/KoUpdater.cpp <span style="color: grey">(484d7e4)</span></li>
<li>libs/main/KoUpdaterPrivate_p.cpp <span style="color: grey">(eae2e54)</span></li>
<li>libs/main/OutOfProcessLoad/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/OutOfProcessLoad/KoFilterLoader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/OutOfProcessLoad/KoFilterLoader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/OutOfProcessLoad/KoOutOfProcessLoad.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/OutOfProcessLoad/KoOutOfProcessLoad.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/OutOfProcessLoad/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(77fb02f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101794/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>