Committing kundo2 patches tomorrow

[Jaroslaw Staniek]

On 25 June 2011 23:02, Alexander Potashev <aspotashev at gmail.com> wrote:
> 2011/6/25 Jaroslaw Staniek <staniek at kde.org>:
>> Hi,
>> Kudos for this contribution but is KUndo2 tested at all, especially with Kexi?
>> Isn't there a clear infinite recursion at kundo2stack.cpp:1065 and 1084?
>
> That's clearly my mistake, sorry. Fixed in master, but in a different
> way than you suggested.
>
> I probably didn't test Kexi with kundo2, I don't remember exactly. But
> now I tested Kexi and I couldn't reproduce the crash due to stack
> overflow (well, I made Kexi crash in 20 seconds, but it has nothing to
> do with recursion).

Your fix (while unnecessarily complex ;) ) also fixes related problem for kexi.

>
>
> --
> Alexander Potashev
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>



-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)