Review Request: one memory leak, 7 exceptions and two comparations.
Jaime Torres Amate
jtamate at gmail.com
Wed Jun 22 22:46:19 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101730/
-----------------------------------------------------------
Review request for Calligra.
Summary
-------
The two comparations are obvious.
The memory leak, I think Qt will not delete them.
The exceptions, following C++ style guides, the variable is preferred by reference.
Diffs
-----
filters/karbon/applixgraphics/applixgraphicimport.cc e8407fd
filters/kpresenter/powerpoint/ParsedPresentation.cpp 0f375b9
filters/libmso/ODrawToOdf.cpp 6551a62
filters/tables/excel/sidewinder/format.h e744a1c
Diff: http://git.reviewboard.kde.org/r/101730/diff
Testing
-------
Thanks,
Jaime Torres
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110622/f0e03cd4/attachment.htm>
More information about the calligra-devel
mailing list