Review Request: Store text:soft-page-break as KoInlineObject.

[Casper Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101708/#review4056
-----------------------------------------------------------

Ship it!


- Casper


On June 21, 2011, 4:54 a.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101708/
> -----------------------------------------------------------
> 
> (Updated June 21, 2011, 4:54 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Store text:soft-page-break as a KoInlineObject. 
> 
> That avoids the following 3 problems:
> - displaying [] character for soft page break
> - saving of the soft-page-break as text:line-break
> - roundtrip not working.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/CMakeLists.txt b0f40d1 
>   libs/kotext/KoTextSoftPageBreak.h PRE-CREATION 
>   libs/kotext/KoTextSoftPageBreak.cpp PRE-CREATION 
>   libs/kotext/opendocument/KoTextLoader.cpp 26d4c1b 
>   libs/textlayout/KoTextLayoutArea.cpp b98eec2 
> 
> Diff: http://git.reviewboard.kde.org/r/101708/diff
> 
> 
> Testing
> -------
> 
> Roundtrip is working and the [] charater is no longer happening also no text:line-break is inserted on saving.
> 
> 
> Thanks,
> 
> Thorsten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110621/4588c6ec/attachment.htm>