Review Request: Anchored shape positioning fix

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101532/#review3759
-----------------------------------------------------------


When testing the patch some random files I found one problem.

Looks like shapes are placed at the end of the page while they should move to the next page. The space where the shape should be on the next is kept free. Other then that it fixes one very nasty anchor problem where all images where put on the first page. I have uploaded some test files to:

http://www.zagge.de/anchor/anchorbug/

There is a short info file that says what is changed.

I think this wrong anchoring to the previous page should be fixed and after that I can run my test docs ones more to see if nothing  broke.

- Thorsten


On June 7, 2011, 12:49 p.m., Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101532/
> -----------------------------------------------------------
> 
> (Updated June 7, 2011, 12:49 p.m.)
> 
> 
> Review request for Calligra, Casper Boemann and Sebastian Sauer.
> 
> 
> Summary
> -------
> 
> This is reimplementation of the old layout anchor logic.
> 
> The idea behind it is to releayout the text after every successful positioning of wrapping shape.
> And let it there where it was positioned the first time.
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/FloatingAnchorStrategy.cpp f5b780c 
>   libs/textlayout/InlineAnchorStrategy.cpp 24908ee 
>   libs/textlayout/KoTextDocumentLayout.cpp 3819b22 
>   libs/textlayout/KoTextLayoutArea.cpp c822879 
> 
> Diff: http://git.reviewboard.kde.org/r/101532/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110608/38eacaeb/attachment.htm>