<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101532/">http://git.reviewboard.kde.org/r/101532/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When testing the patch some random files I found one problem.
Looks like shapes are placed at the end of the page while they should move to the next page. The space where the shape should be on the next is kept free. Other then that it fixes one very nasty anchor problem where all images where put on the first page. I have uploaded some test files to:
http://www.zagge.de/anchor/anchorbug/
There is a short info file that says what is changed.
I think this wrong anchoring to the previous page should be fixed and after that I can run my test docs ones more to see if nothing broke.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On June 7th, 2011, 12:49 p.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Casper Boemann and Sebastian Sauer.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated June 7, 2011, 12:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is reimplementation of the old layout anchor logic.
The idea behind it is to releayout the text after every successful positioning of wrapping shape.
And let it there where it was positioned the first time.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/textlayout/FloatingAnchorStrategy.cpp <span style="color: grey">(f5b780c)</span></li>
<li>libs/textlayout/InlineAnchorStrategy.cpp <span style="color: grey">(24908ee)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: grey">(3819b22)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(c822879)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101532/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>