Review Request: Anchored shape positioning fix

[Sebastian Sauer]

> On June 7, 2011, 1:17 p.m., Casper Boemann wrote:
> > Thanks for working on this. I'm no totally against it, but just a bit worried it's a gainst the odf spec, so I'm going to have to take a closer look.
> > 
> > 
> > 
> >  I think it's good, but as i said i really neeed to look this through which is probably going to take more than a day, considering i'm on vacation. Sebastian you can look too please, but i'd like to at least have a say before we okay this

Looks fine to me except that I am not sure there re the return false/true changes in the Floating-/InlineAnchorStrategy.
This also fixes https://bugs.kde.org/show_bug.cgi?id=260143 what absolute rocks (thanks Hanzes :-)
I could test a bit more today and if I don't run into regressions I would suggest to take it over cause it's at least better then it was before. I also believe it invalidates my alternate suggestion in the textlayout-fix-infinite-anchor-loop-sebsauer branch and is indeed the better way to solve it.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101532/#review3742
-----------------------------------------------------------


On June 7, 2011, 12:49 p.m., Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101532/
> -----------------------------------------------------------
> 
> (Updated June 7, 2011, 12:49 p.m.)
> 
> 
> Review request for Calligra, Casper Boemann and Sebastian Sauer.
> 
> 
> Summary
> -------
> 
> This is reimplementation of the old layout anchor logic.
> 
> The idea behind it is to releayout the text after every successful positioning of wrapping shape.
> And let it there where it was positioned the first time.
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/FloatingAnchorStrategy.cpp f5b780c 
>   libs/textlayout/InlineAnchorStrategy.cpp 24908ee 
>   libs/textlayout/KoTextDocumentLayout.cpp 3819b22 
>   libs/textlayout/KoTextLayoutArea.cpp c822879 
> 
> Diff: http://git.reviewboard.kde.org/r/101532/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110607/8097e448/attachment.htm>