<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101532/">http://git.reviewboard.kde.org/r/101532/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 7th, 2011, 1:17 p.m., <b>Casper Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for working on this. I'm no totally against it, but just a bit worried it's a gainst the odf spec, so I'm going to have to take a closer look.
I think it's good, but as i said i really neeed to look this through which is probably going to take more than a day, considering i'm on vacation. Sebastian you can look too please, but i'd like to at least have a say before we okay this </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me except that I am not sure there re the return false/true changes in the Floating-/InlineAnchorStrategy.
This also fixes https://bugs.kde.org/show_bug.cgi?id=260143 what absolute rocks (thanks Hanzes :-)
I could test a bit more today and if I don't run into regressions I would suggest to take it over cause it's at least better then it was before. I also believe it invalidates my alternate suggestion in the textlayout-fix-infinite-anchor-loop-sebsauer branch and is indeed the better way to solve it.
</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On June 7th, 2011, 12:49 p.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Casper Boemann and Sebastian Sauer.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated June 7, 2011, 12:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is reimplementation of the old layout anchor logic.
The idea behind it is to releayout the text after every successful positioning of wrapping shape.
And let it there where it was positioned the first time.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/textlayout/FloatingAnchorStrategy.cpp <span style="color: grey">(f5b780c)</span></li>
<li>libs/textlayout/InlineAnchorStrategy.cpp <span style="color: grey">(24908ee)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: grey">(3819b22)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(c822879)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101532/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>