reviewrequest

[Jaroslaw Staniek]

On 6 June 2011 13:31, Boudewijn Rempt <boud at valdyas.org> wrote:
> On Monday 06 June 2011 Jun, Jaroslaw Staniek wrote:
>> On 6 June 2011 12:46, Boudewijn Rempt <boud at valdyas.org> wrote:
>> > On Monday 06 June 2011 Jun, Jaroslaw Staniek wrote:
>> >> Great work. Would the next step be s/Ko/Ca/g ?
>> >
>> > I wasn't planning on that -- I would be afraid of breaking too much history, and besides, those prefixes aren't that important. Krita's prefix still is kis.... The next step would actually be to remove all the references to kword, kspread, kpresenter, kivio and kplato:
>> >
>>
>> Another note: some of our code uses namespaces, we started to use
>> Calligra namespace too. How about removing Ko prefix and have Calligra
>> for public libs, and optionally {appname} for apps (if app maintainer
>> agrees)?
>
> Well, I like prefixes much better than namespaces. Code with namespaces but no prefixes tend to agglomerate many files with exactly the same name and classes with exactly the same name, which is confusing to me.

That's also confusing to me. We should think what to do with the use
of Calligra::Tables namespaces to be consistent.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)