Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.
Jan Hambrecht
jaham at gmx.net
Sun Jul 31 22:37:46 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102072/#review5288
-----------------------------------------------------------
I just tested your code, looks good so far. Regarding the painting artifacts while moving, I think these are caused by not taking the blur radius into account when calculating the insets of the shadow.
libs/flake/KoShapeGroup.h
<http://git.reviewboard.kde.org/r/102072/#comment4790>
Unrelated change, please revert.
libs/flake/KoShapeGroup.cpp
<http://git.reviewboard.kde.org/r/102072/#comment4791>
Unrelated change, please revert.
libs/flake/KoShapeShadow.h
<http://git.reviewboard.kde.org/r/102072/#comment4792>
There is a private d-pointer, so please move these to the private class
- Jan
On July 29, 2011, 3:47 a.m., Yue Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102072/
> -----------------------------------------------------------
>
> (Updated July 29, 2011, 3:47 a.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.
>
>
> Diffs
> -----
>
> libs/flake/KoShapeGroup.h 5ccd57406ed46bf2dc443bc80df90621011b4a05
> libs/flake/KoShapeGroup.cpp aaa58b4413f7d8bd10d0805c733cd3799052a886
> libs/flake/KoShapeShadow.h 07c760c4cecd3050ecd6af9c4040c2f859242abe
> libs/flake/KoShapeShadow.cpp 5485b19109a179845e0b17827025a5c64d378221
> libs/widgets/KoShadowConfigWidget.cpp 1a410421831aec2e1668bb82c65d652f6c6fdbd1
> plugins/dockers/shadowdocker/ShadowDocker.cpp ef53fae66ef2f4910eb13726ee9621a4a98c83e3
>
> Diff: http://git.reviewboard.kde.org/r/102072/diff
>
>
> Testing
> -------
>
> http://my.cdash.org/viewTest.php?onlydelta&buildid=212010
>
>
> Screenshots
> -----------
>
> groupshadow / shape shadow
> http://git.reviewboard.kde.org/r/102072/s/210/
>
>
> Thanks,
>
> Yue
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110731/0526d322/attachment.htm>
More information about the calligra-devel
mailing list