Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.
Yue Liu
opuspace at gmail.com
Fri Jul 29 04:47:46 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102072/
-----------------------------------------------------------
(Updated July 29, 2011, 3:47 a.m.)
Review request for Calligra.
Changes
-------
everything commented fixed, but the shadow boundingRect expansion is still not correct, there are still visual garbages when moving the shape with blured shadow. I'm confused what's wrong there, please give some advices.
Summary
-------
Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.
Diffs (updated)
-----
libs/flake/KoShapeGroup.h 5ccd57406ed46bf2dc443bc80df90621011b4a05
libs/flake/KoShapeGroup.cpp aaa58b4413f7d8bd10d0805c733cd3799052a886
libs/flake/KoShapeShadow.h 07c760c4cecd3050ecd6af9c4040c2f859242abe
libs/flake/KoShapeShadow.cpp 5485b19109a179845e0b17827025a5c64d378221
libs/widgets/KoShadowConfigWidget.cpp 1a410421831aec2e1668bb82c65d652f6c6fdbd1
plugins/dockers/shadowdocker/ShadowDocker.cpp ef53fae66ef2f4910eb13726ee9621a4a98c83e3
Diff: http://git.reviewboard.kde.org/r/102072/diff
Testing
-------
http://my.cdash.org/viewTest.php?onlydelta&buildid=212010
Screenshots
-----------
groupshadow / shape shadow
http://git.reviewboard.kde.org/r/102072/s/210/
Thanks,
Yue
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110729/994e849c/attachment.htm>
More information about the calligra-devel
mailing list