Review Request: nofill and nostroke support in enhanced path from odf

[Jan Hambrecht]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101873/#review4656
-----------------------------------------------------------


Great work, please find attached some comments from myself.


libs/flake/KoPathShape.h
<http://git.reviewboard.kde.org/r/101873/#comment4084>

    I would prefer the inverse order of the parameters.



libs/flake/KoPathShape.h
<http://git.reviewboard.kde.org/r/101873/#comment4085>

    I would prefer the inverse order of the parameters.



libs/flake/KoSubpath.h
<http://git.reviewboard.kde.org/r/101873/#comment4092>

    missing indentation



libs/flake/KoSubpath.h
<http://git.reviewboard.kde.org/r/101873/#comment4086>

    Should be void close();



libs/flake/KoSubpath.h
<http://git.reviewboard.kde.org/r/101873/#comment4087>

    Should be void closeMerge();



libs/flake/KoSubpath.h
<http://git.reviewboard.kde.org/r/101873/#comment4088>

    Should be called appenToPath.



libs/flake/KoSubpath.cpp
<http://git.reviewboard.kde.org/r/101873/#comment4091>

    wrong indentation



libs/flake/KoSubpath.cpp
<http://git.reviewboard.kde.org/r/101873/#comment4090>

    wrong indentation



libs/flake/KoSubpath.cpp
<http://git.reviewboard.kde.org/r/101873/#comment4089>

    Missing indentation.



libs/flake/KoSubpath.cpp
<http://git.reviewboard.kde.org/r/101873/#comment4093>

    please remove superfluous empty lines


- Jan


On July 12, 2011, 3:59 p.m., Lukáš Tvrdý wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101873/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 3:59 p.m.)
> 
> 
> Review request for Calligra, Jan Hambrecht and Thorsten Zachmann.
> 
> 
> Summary
> -------
> 
> This patch implements S and F commands in draw:enhanced-path. So far there were no support for this.
> 
> The idea is that the path is now rendered per sub-path, because S (no stroke) and F (no fill) can be 
> specified per subpath in the draw:enhanced-path.
> 
> I changed typedef KoSubpath to standalone class as it needs attributes about no fill and no stroke.
> I moved the code that operates only on KoSubpath to that class from KoPathShape.
> Then I render the output per QPainterPath with appropriate attributes (I turn off the pen temporary if no stroke and turn of the brush if no fill)
> 
> 
> This addresses bug 239561.
>     http://bugs.kde.org/show_bug.cgi?id=239561
> 
> 
> Diffs
> -----
> 
>   karbon/plugins/tools/CalligraphyTool/KarbonSimplifyPath.cpp d292508 
>   libs/flake/CMakeLists.txt b9f388f 
>   libs/flake/KoPathShape.h 8b54f26 
>   libs/flake/KoPathShape.cpp da6c928 
>   libs/flake/KoPathShape_p.h e1e2843 
>   libs/flake/KoSubpath.h PRE-CREATION 
>   libs/flake/KoSubpath.cpp PRE-CREATION 
>   libs/flake/commands/KoSubpathRemoveCommand.cpp 79894f0 
>   plugins/pathshapes/ellipse/EllipseShape.cpp 0576f5d 
>   plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp a58d67e 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 46d76de 
>   plugins/pathshapes/star/StarShape.cpp 5fc8562 
> 
> Diff: http://git.reviewboard.kde.org/r/101873/diff
> 
> 
> Testing
> -------
> 
> From bug 239561:
> a) before patch http://wstaw.org/m/2011/07/07/nofill_nostroke_example_before.png
> b) with my patch http://wstaw.org/m/2011/07/07/nofill_nostroke_example_after.png
> 
> I first managed to break several unit tests (TestPointMergeCommand and TestPathShape), 
> but I fixed all the problems and no tests are broken by this patch now.
> 
> 
> Thanks,
> 
> Lukáš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110712/9a956ab8/attachment.htm>