Review Request: nofill and nostroke support in enhanced path from odf

Lukáš Tvrdý at
Tue Jul 12 17:59:40 CEST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated July 12, 2011, 3:59 p.m.)

Review request for Calligra, Jan Hambrecht and Thorsten Zachmann.


Fixing compilation with Karbon

o by painting with calligraphy tool that simplify the path


This patch implements S and F commands in draw:enhanced-path. So far there were no support for this.

The idea is that the path is now rendered per sub-path, because S (no stroke) and F (no fill) can be 
specified per subpath in the draw:enhanced-path.

I changed typedef KoSubpath to standalone class as it needs attributes about no fill and no stroke.
I moved the code that operates only on KoSubpath to that class from KoPathShape.
Then I render the output per QPainterPath with appropriate attributes (I turn off the pen temporary if no stroke and turn of the brush if no fill)

This addresses bug 239561.

Diffs (updated)

  karbon/plugins/tools/CalligraphyTool/KarbonSimplifyPath.cpp d292508 
  libs/flake/CMakeLists.txt b9f388f 
  libs/flake/KoPathShape.h 8b54f26 
  libs/flake/KoPathShape.cpp da6c928 
  libs/flake/KoPathShape_p.h e1e2843 
  libs/flake/KoSubpath.h PRE-CREATION 
  libs/flake/KoSubpath.cpp PRE-CREATION 
  libs/flake/commands/KoSubpathRemoveCommand.cpp 79894f0 
  plugins/pathshapes/ellipse/EllipseShape.cpp 0576f5d 
  plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp a58d67e 
  plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 46d76de 
  plugins/pathshapes/star/StarShape.cpp 5fc8562 



>From bug 239561:
a) before patch
b) with my patch

I first managed to break several unit tests (TestPointMergeCommand and TestPathShape), 
but I fixed all the problems and no tests are broken by this patch now.



-------------- next part --------------
An HTML attachment was scrubbed...

More information about the calligra-devel mailing list