Review Request: unused-but-set-variable-warning

Sune Vuorela kde at pusling.com
Sun Jul 10 22:10:31 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101911/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

The commented out code looks like it is trying to read a string, 'count', then parsing the content of 'count' as a integer into 'countNumber' and then trowing it all away.

The code at least gives a compiler warning about countNumber set, but never used. I'm not 100% sure that my analysis above is correct.

The right fix is probably to not #if 0 the code out, but to remove it completely, assuming my analysis is correct.


Diffs
-----

  filters/tables/xlsx/XlsxXmlStylesReader.cpp 55ccd1ae73b29f4f93140fd906ee218dd4887623 

Diff: http://git.reviewboard.kde.org/r/101911/diff


Testing
-------

Code compiles without warnings.


Thanks,

Sune

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110710/518c8028/attachment.htm>


More information about the calligra-devel mailing list