Review Request: more methods made const

[Jaime Torres Amate]

> On July 3, 2011, 8:52 p.m., Sebastian Sauer wrote:
> > - bool operator==(BaseIterator it)
> > + bool operator==(BaseIterator it) const
> > 
> > While reading that part of the patch I was asking myself if there are compilers who would see those both methods as different and then jump in and generate the non-const one?
> > I don't remember any such thing in any C++ pitfall-doc but then I am not 100% sure so better ask to prevent us ending with something unwanted :)
> >

Look at the end of
http://www.cs.caltech.edu/courses/cs11/material/cpp/donnie/cpp-ops.html  or
http://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B

In fact, the operator should be
+ bool operator==(const BaseIterator &it) const


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101843/#review4358
-----------------------------------------------------------


On July 3, 2011, 6:17 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101843/
> -----------------------------------------------------------
> 
> (Updated July 3, 2011, 6:17 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Second and last const methods conversion. 
> the remaining methods that could be const are empty.
> 
> 
> Diffs
> -----
> 
>   karbon/plugins/tools/KarbonCurveFit.cpp 809ca13 
>   karbon/plugins/tools/KarbonGradientEditStrategy.h 648ce2b 
>   kexi/webforms/model/Cache.h 0ce376b 
>   kpresenter/part/pagelayout/KPrPlaceholder.h d4e7515 
>   kpresenter/part/pagelayout/KPrPlaceholder.cpp babbe35 
>   krita/image/tests/kis_random_generator_demo.h b76e492 
>   krita/image/tests/kis_random_generator_demo.cpp cc9b2c1 
>   krita/plugins/extensions/tonemapping/lib/kis_tone_mapping_operator.h ecce2c2 
>   krita/plugins/extensions/tonemapping/lib/kis_tone_mapping_operator.cc 17d3ccc 
>   krita/plugins/paintops/dynadraw/filter.h 7e8fd31 
>   krita/plugins/paintops/hairy/hairy_brush.h 9664d3d 
>   krita/plugins/paintops/hairy/trajectory.h 47541a2 
>   krita/plugins/paintops/spray/spray_brush.h a00faf4 
>   krita/plugins/tools/tool_curves/kis_curve_framework.h 61c68ac 
>   krita/ui/widgets/newKisCurveWidget/curveWidget/kis_shared.h 607bfec 
>   libs/kotext/changetracker/KoDeletedCellData.h 2d02ff2 
>   libs/kotext/changetracker/KoDeletedCellData.cpp 577b534 
>   libs/main/tests/rtreetestapp.h c319a3c 
>   plugins/pathshapes/enhancedpath/EnhancedPathFormula.h a67fdc2 
>   plugins/vectorshape/libemf/BitmapHeader.h 92ac3db 
> 
> Diff: http://git.reviewboard.kde.org/r/101843/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110704/ba08877e/attachment.htm>